Better support for user pre-amble

[levon]

All the packages loaded automatically by lyx (e.g.
a4, babel) will appear
in the user preamble. Also the \makeatletter ..
\makeatother commands will
appear in the user preamble.

Additionally, packages in the user preamble will be
duplicated in the lyx preamble if they are needed by lyx,
even overriding user options.

[lasgouttes]

I think I do not understand this bug report :)

[levon]

I don't follow the first paragraph either. But isn't the second true:
if a user wants a non-standard option on a package lyx decides it needs itself,
lyx will use its own options overriding the users ?

Obviously I don't know this stuff ...

[levon]

this is about relyx import btw. The component is wrong I think.

[levon]

Re-assigning relyx bugs to Kayvan

[levon]

Mass move to 1.2.0 - grep out the bugspam with "Dharma ex one+one"

[levon]

testcase

[levon]

Here's an example of the first problem. LyX generated the use of graphicx,
but when you import it, it appears in the /user/ preamble.

[Juergen Spitzmueller]

Same problem with tex2lyx. Changing component, since reLyX is unmaintained.

[José Matos]

tex2lyx takes care of all the packages in the preamble as well as the
language. And it also takes care of graphics (see #22, closed yesterday).

Now the only thing that remains to do is to remove the lyx generated comments.

Since this is a small issue I classify the issue as an enhancement and I will
set 1.5.0 as target to this bug and I will assign the bug to me.

[levon]

Could consider earlier (1.4.1)

[lasgouttes]

not going to happen in 1.4.1, it seems.

[lasgouttes]

I is a bit more than an enhancement, since it prevents round-trip in french
(#2438).

A work around would be, if we are in a part of preamble generated by LyX, to
just drop lines we do not interpret instead of copying them in preamble.

[jeanpierre.chretien@…]

I added a comment in dependent #2438, I reproduce it here:

Another example is a roundtrip with a document using the geometry package:
it comes back with an inserted preamble which contains the exported
geometry stuff, so that any change in geometry from theDocument->Settings->Page
layout is not taken into account, as it is exported before the preamble.

The problem is not only with round trip I guess, should not
tex2lyx remove from the preamble the settings it can convert as
lyx commands which are exported in the preamble ?
Unless tex2lyx doe not try to convert as lyx commands at all ?
In which case, it might be better to drop the commands in the preamble
which are natively exported by lyx and to leave the user with the task
to re-set these commands, but this seems worse to me than lo leave him
the task to delete them him(her)self.

[jeanpierre.chretien@…]

I'v tested the patch of comment #14 on lyx-1.4.3/Solaris,
on a test file that I will attach next.

This test file includes French guillemets (see #2438),
geometry package, a plain figure.

The result works fine, however looking at the preamble, there is an exra
\makeatother command, which is swallowed by the latex export function.

[jeanpierre.chretien@…]

Lyx test file for roudtrip test

[Richard Heck]

Resetting target from 1.4.x to 1.6.0.

[Uwe Stöhr]

I fixed the extra \makeatother command problematic and the guillemets issue a
while ago. #2438 is fixedintrunk, so the only missing thing is support for
the geometry settings that is now #4826.

Marking this as fixedintrunk.

[lasgouttes]

I still think that my patches (that I never committed for a reason I do not
understand) make sense and should be applied. The code added by LyX should
be automatically discarded to improve roundtrip.

[Juergen Spitzmueller]

Jean-Marc, if you think your patches make sense, just go ahead and commit them.

[Uwe Stöhr]

The code added by LyX should be automatically discarded to improve roundtrip.

How will you do this? People might have slightly adopt it. Furthermore the code
LyX adds to the preamble has been changed from time to time due to bugfixes,
optimizations, etc.

[lasgouttes]

update of attachment 1341 for branch

[lasgouttes]

Tentative patch for 1.5

[lasgouttes]

The principle of this patch is to omit from LyX-generated .tex files ("%% LyX .*
created this file") all the preamble snippets that are before

%%%%%%%% User specified LaTeX commands

The reason I did not put it in at the time is that LyX should also output a

%%%%%%%% End user specified LaTeX commands

and tex2lyx should act on it if it is present.

Concerning the ugly things that users may have been doing to their tex files,
note that every file starts with

%% Do not edit unless you really know what you are doing.

What I have to do next is test (but I'd appreciate independent testing) and
maybe implement the `End user specified LaTeX commands' thing.

[Uwe Stöhr]

LyX testfile for the \makebox issue

[Uwe Stöhr]

TeX output of attachment 2571

[lasgouttes]

same patch for trunk

[Uwe Stöhr]

actualized patch

[Uwe Stöhr]

I updated your patch to latest trunk (I also changed some whitespace). I tested
it and it works well, except of this issue:

Take the LyX file attachment 2571 and export it as LaTeX, the result is
attachment 2572. When you import it to LyX, you get the \makeatother in the
preamble, but the original preamble didn't have that.

This could be fixed the following way: When the current \makeatother is the last
entry in the file before \begin{document}, it must be omitted as LyX sets it
again. So the structure is something like

else if (t.cs() == "makeatother") {

if ( (!is_lyx_file

!in_lyx_preamble

p.getCatCode('@') != catOther)

&& (p.next_token().asInput() == "
begin{document}") )

h_preamble << "
makeatother";

p.setCatCode('@', catOther);
}

Concerning the ugly things that users may have been doing to their tex files,
note that every file starts with

%% Do not edit unless you really know what you are doing.

This doesn't count. I know what I am doing and I often modify the TeX output of
LyX files to be able to send it to colleagues. I normally left LyX's comment
lines like

%%%%%%%% User specified LaTeX commands

intact.
But OK, for a round trip support we must assume that e.g. the

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% LyX specific LaTeX commands.

section is not changed by the user - I think we can do this. So the patch is
fine with me and should go in when the \makeatother issue is fixed as described.

What I have to do next is test (but I'd appreciate independent testing) and
maybe implement the `End user specified LaTeX commands' thing.

I don't think this is needed.

[Uwe Stöhr]

Ping, JMarc?

[lasgouttes]

Sorry to be so slow. I did not forget about it and will eventually (!) commit it.

[Uwe Stöhr]

I did not forget about it and will eventually (!) commit it.

Please put it in. I've been working with your patch included since months now
and it is stable.

[Uwe Stöhr]

Please put it in. I've been working with your patch included since months now
and it is stable.

@JMarc: As the patch is really stable and you didn't reply, I put it in. I hope
this is OK with you.

fixedintrunk: ​http://www.lyx.org/trac/changeset/26603

[lasgouttes]

You did the right ting, thanks. I just committed a few whitespace problems.

[Juergen Spitzmueller]

LyX 1.6.0 is released.