Opened 20 years ago

Closed 15 years ago

#2116 closed defect (fixed)

Bug when inserting reference to a label with spaces in math mode

Reported by: gadykozma@… Owned by: nobody@…
Priority: normal Milestone: 1.6.6
Component: mathed Version: 1.4.1
Severity: normal Keywords:
Cc: poenitz@…, michael.gerz@…, Uwe Stöhr, Richard Heck

Description (last modified by ps)

Steps to reproduce the problem:

  1. Create a label with spaces in it e.g. "bad bug"
  2. Start math mode
  3. Insert a reference to "bad bug"
  4. Export Latex

Actual Results:

$\ref{badbug}$, the space is deleted.

Attachments (1)

georg-051108.patch (3.8 KB ) - added by Georg Baum 20 years ago.
fix for 1.4

Download all attachments as: .zip

Change History (23)

comment:1 by lasgouttes, 20 years ago

Cc: poenitz@… added
op_sys: LinuxAll
rep_platform: PCAll
Version: unspecified1.3.6

I was not aware that it is possible to insert refs in maths...

I can confirm the bug in 1.3.7cvs. On 1.4.0cvs, it seems that the feature
is disabled altogether. Probably André knows.

André?

comment:2 by gadykozma@…, 20 years ago

I've seen talk on disabling this feature (refs in math). Please don't. It's a
very important feature.

comment:3 by Juergen Spitzmueller, 20 years ago

* #2118 has been marked as a duplicate of this bug. *

by Georg Baum, 20 years ago

Attachment: georg-051108.patch added

fix for 1.4

comment:4 by Georg Baum, 20 years ago

Milestone: 1.4.1

References are reenabled in 1.4 now, but this bug is still there. It will not
be fixed for 1.4.0, but since it is not too difficult to do I target it for
1.4.1.

comment:5 by Uwe Stöhr, 19 years ago

Keywords: patch added

comment:6 by lasgouttes, 19 years ago

Why do you remove code for LFUN_INSET_APPLY in math_nestinset.C?

comment:7 by Uwe Stöhr, 19 years ago

Cc: uwestoehr@… added

comment:8 by Georg Baum, 19 years ago

Because it is never executed and no other inset has code for that.
LyXFunc::dispatch resolves it either to LFUN_INSET_MODIFY or LFUN_INSET_INSERT.
I can as well take this out for 1.4 if you like, but for 1.5 I'd like to get
rid of it.

comment:9 by Georg Baum, 19 years ago

Keywords: patch removed

Forget my last comment. The patch is already applied (see comment 5).

comment:10 by lasgouttes, 19 years ago

Milestone: 1.4.11.4.2

move bugs to 1.4.2. Sorry for the spam

comment:11 by Uwe Stöhr, 19 years ago

Version: 1.3.61.4.1

comment:12 by lasgouttes, 19 years ago

Milestone: 1.4.21.4.x

comment:13 by Juergen Spitzmueller, 19 years ago

Cc: michael.gerz@… added

comment:14 by Juergen Spitzmueller, 19 years ago

* #1369 has been marked as a duplicate of this bug. *

comment:15 by Richard Heck, 18 years ago

Milestone: 1.4.x1.5.x

Moving all bugs targeted to before 1.5.0 to 1.5.x.

If these are yours, please check that they have not been fixed and, if so, close
them.

Otherwise, sorry for the spam.

comment:16 by Juergen Spitzmueller, 17 years ago

Milestone: 1.5.x1.6.x

1.5.x is frozen. Shifting all 1.5.x-targetted bugs to 1.6.x.

If you have reported this bug, please verify if it still occurs in 1.6.0 and
close the report, if not.

comment:17 by ps, 16 years ago

Priority: highnormal

comment:18 by ps, 16 years ago

Description: modified (diff)
Keywords: easyfix added

it is not too difficult to do I target it for 1.4.1.

putting in 2.0 radar.

comment:19 by Vincent van Ravesteijn, 15 years ago

Cc: Uwe Stöhr Richard Heck added; uwestoehr@… removed
Keywords: fixedintrunk added; easyfix removed
Milestone: 1.6.x2.0.0

This seems to be fixed in trunk now, but not in branch.

Anyone knows how this got fixed and how to backport to branch ?

comment:20 by ps, 15 years ago

r33324 is what you are looking for

comment:21 by Vincent van Ravesteijn, 15 years ago

Keywords: fixedinbranch added
Milestone: 2.0.01.6.6

Thanks,

so also fixed in branch in r33332.

comment:22 by Juergen Spitzmueller, 15 years ago

Keywords: fixedintrunk fixedinbranch removed
Resolution: fixed
Status: newclosed

1.6.6 is done.

Note: See TracTickets for help on using tickets.