Opened 18 years ago

Closed 14 years ago

#2179 closed defect (fixed)

LaTeX and chktex error handling problems.

Reported by: John C. McCabe-Dansted Owned by: nobody@…
Priority: normal Milestone: 1.6.6
Component: dialogs Version: 1.5.0svn
Severity: normal Keywords:
Cc: Juergen Spitzmueller, jeanpierre.chretien@…

Description (last modified by Uwe Stöhr)

The new "LaTeX Errors" Error dialog box has some problems:

  • It always jumps back to and highlights the first error when I go back to the main LyX window, regardless of which error I clicked on in the dialog box.
  • It makes it hard to edit the text, as it keeps the (first) error

selected/highlighted, typing anything deletes the error text.

  • Ctrl+G no longer selects the next error. This may be intentional, but it seems that it would be very handy if Ctrl+G brought the LaTeX error dialog to the foreground and jumped to the next error.

My system:
LyX-1.4.0pre3
kubuntu 5.10 (upgraded from preview)
gcc 4.02
QT 3.3.4
KDE 3.5
Intel(R) Pentium(R) 4 CPU 1500MHz

Attachments (1)

GuiErrorList.cpp.patch (654 bytes ) - added by gmatht 15 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 by Juergen Spitzmueller, 18 years ago

Cc: j.spitzmueller@… added

confirmed. Also, if you undo some action while the error dialog is open, the
par IDs change, and the dialog does not find the errors anymore.
This is really nasty.
Note, however, that the selection doesn't jump back if you really close the
dialog, and I think the dialog should be closed anyway, because the error
status changes when you edit the document.
I propose the following:

  • add a menu option to reopen the error dialog (which probably has to rerun

latex or whatever the last action was)

  • reimplement error-next which opens the dialog and jumps to the next error

from cursor position

  • disallow editing while the error dialog is open

or, more elegant:

  • the error dialog automatically updates its information when the document has

been edited. This might be not trivial, though (simply due to the par id
situation).

comment:2 by lasgouttes, 18 years ago

Component: frontend-qt2dialogs
Milestone: 1.4.x
op_sys: LinuxAll
Version: 1.4.0cvs1.4.1

The par id situation is now better, fixing the way the error dialog works would be
very welcome indeed.

comment:3 by lasgouttes, 18 years ago

Milestone: 1.4.x1.5.0

Fixed in 1.4 branch. Abdel is making changes in trunk, this will have to be
fixed later

Url: http://www.lyx.org/trac/changeset/14655
Log:
Fix #2179

  • controllers/ControlErrorList.h (unreadlist_): new member, tells whether the errorlist has been read by the dialog.
  • controllers/ControlErrorList.C (errorList, initialiseParams): update unreadlist_ as needed.
  • qt2/QErrorList.C (update_contents): do nothing if error list has not been updated (#2179).
  • xforms/FormErrorList.C (update): do not call updateContents if the error list has not been updated (#2179).

comment:4 by Uwe Stöhr, 18 years ago

Keywords: fixedintrunk added

comment:5 by Juergen Spitzmueller, 18 years ago

Keywords: fixedintrunk removed

Removing "fixedintrunk" keyword, because that's exactly what it's not.

comment:6 by Uwe Stöhr, 18 years ago

Version: 1.4.11.5.0svn

comment:7 by lasgouttes, 18 years ago

And there is still the part that Ctrl+G does not work. This is now #2775.

comment:8 by Juergen Spitzmueller, 17 years ago

Jean-Marc, what's the status of this? Should this be fixed for 1.5.0?

comment:9 by John C. McCabe-Dansted, 17 years ago

It was fixed in 1.4.3, except for the bit split off as #2775. I hope it is
still fixed in 1.5.0.

comment:10 by Juergen Spitzmueller, 17 years ago

As I understand it, the fix has been applied to the 1.4 branch back then, but
not to trunk (I have not checked that, though). If it's not too complicated, it
should be fixed in 1.5 as well before release.

comment:11 by younes, 17 years ago

Resolution: fixed
Status: newclosed

I fixed it differently in 1.5svn.

http://www.lyx.org/trac/changeset/16848

comment:12 by John C. McCabe-Dansted, 15 years ago

Resolution: fixed
Status: closedreopened

This bug appears to have reoccurred in LyX 1.6.x, in particular, I can reproduce
it in 1.6.2svn.

comment:13 by Vincent van Ravesteijn, 15 years ago

Description: modified (diff)
Milestone: 1.5.01.6.x

comment:14 by ps, 15 years ago

Priority: highnormal

by gmatht, 15 years ago

Attachment: GuiErrorList.cpp.patch added

comment:15 by Uwe Stöhr, 14 years ago

Cc: Juergen Spitzmueller jeanpierre.chretien@… added; j.spitzmueller@… removed
Description: modified (diff)
Keywords: patch added
Milestone: 1.6.x1.6.6

comment:16 by Vincent van Ravesteijn, 14 years ago

Keywords: fixedintrunk added; patch removed

Fixed in trunk at r32222.

comment:17 by Juergen Spitzmueller, 14 years ago

Looks good. Go ahead.

comment:18 by Vincent van Ravesteijn, 14 years ago

Keywords: fixedinbranch added

Fixed in branch at r32417.

comment:19 by Juergen Spitzmueller, 14 years ago

Keywords: fixedintrunk fixedinbranch removed
Resolution: fixed
Status: reopenedclosed

1.6.6 is done.

Note: See TracTickets for help on using tickets.