Opened 23 years ago

Closed 23 years ago

Last modified 22 years ago

#352 closed enhancement (fixed)

Keep aspect ratio for lyx view

Reported by: levon Owned by: baruch
Priority: high Milestone: 1.3.0
Component: insetgraphics Version: 1.3.0cvs
Severity: minor Keywords: VERIFIED
Cc: lasgouttes@…, leeming@…, voss@…

Description

Would be nice. A minor feature request ...

Attachments (1)

keeplyxaspectratio.diff (20.0 KB ) - added by lasgouttes 23 years ago.
The patch for 1.2.0

Download all attachments as: .zip

Change History (18)

comment:1 by voss, 23 years ago

Resolution: fixed
Status: newclosed

I have it working in my tree.

on one hand it's some stuff and not a real bug.
on the other it should go into the graphics
part as soon as possible, because it's a real
missing feature.

send the patch monday

comment:2 by levon, 23 years ago

Resolution: fixed
Status: closedreopened

Herb, what happened with this ? OK if we keep the bug open till it's
in the actual tree ?

comment:3 by voss, 23 years ago

Angus has it and it should be applied, because
we really forget this option to implement

comment:4 by levon, 23 years ago

Version: 1.2.0cvs1.2.0

Mass move to 1.2.0 - grep out the bugspam with "Dharma ex one+one"

comment:5 by levon, 23 years ago

Cc: lasgouttes@… added
Milestone: 1.2.1
Severity: enhancementnormal

JMarc if I understand this right, it's a back-compat 1.1.6 thing.

comment:6 by lasgouttes, 23 years ago

It would be great to have the patch attached here. Herbert? Angus?

by lasgouttes, 23 years ago

Attachment: keeplyxaspectratio.diff added

The patch for 1.2.0

comment:7 by lasgouttes, 23 years ago

Milestone: 1.2.11.3.0
Severity: normalenhancement

removing from the 1.2.1 radar

comment:8 by levon, 23 years ago

JMarc, this isn't important ? see comment 5 ..

comment:9 by lasgouttes, 23 years ago

Important for what? I applied it to the 1.2.x branch.

comment:10 by levon, 23 years ago

Version: 1.2.01.3.0cvs

Oh, I see. sorry.

comment:11 by lasgouttes, 23 years ago

I applied the patch to 1.3.0cvs (to avoid bitrot), but there is a part in
InsetGraphicsParams::as_grfxParams with is disabled, because I do not know
how to adapt it to the new grfx::Cache world.

Angus, could you _please_ have a look at it?

comment:12 by voss, 23 years ago

here is a patch against latest cvs from today to get it run.
moved the calculation part into graphics/GraphicImage.C

comment:13 by voss, 23 years ago

bugzilla confuses me, the patch went into #353 ...

comment:14 by lasgouttes, 23 years ago

Resolution: fixed
Status: reopenedclosed

Thanks herbert, I applied it. I'm surprised though that I had to
change a lyxsize_kind to lyxsize_type in insetgraphicsParams.

comment:15 by voss, 23 years ago

uups, but this should be applied long time ago???
size_kind is a better name than size_type, which
is misleading

comment:16 by lasgouttes, 23 years ago

I don't know, this code is really not my part. Feel free to take a look :)

comment:17 by michael.gerz@…, 22 years ago

Keywords: VERIFIED added

Feature available => Status = VERIFIED

Note: See TracTickets for help on using tickets.