Opened 17 years ago

Closed 13 years ago

#3998 closed enhancement (fixed)

Docked advanced search window

Reported by: cucinotta@… Owned by: lasgouttes
Priority: low Milestone: 2.0.0
Component: search Version: 1.5.0svn
Severity: minor Keywords:
Cc: j.spitzmueller@…, uwestoehr@…, alexl@…, younes@…, ps@…

Description (last modified by Tommaso Cucinotta)

Trying to split #3982 (feature enhancement) into multiple subtasks. There, I
proposed a search functionality allowing to type and edit the text to search
just like you do within any document, with the ability to enter text, math
symbols and subexpressions to find, and even other weird things (e.g. finding
labels, captions, styles, tables, floatings, references, etc...).
Here, I'd like to propose to implement the user-interface to such functionality
as a docked window that shows up, as a consequence of a keyboard shortcut or
menu selection, at the bottom of the LyX window. The window would contain a
full-enabled LyX widget allowing to enter the text to search, along with buttons
and checkboxes/radios. Possibly, editing of the search text could be restricted
to entering a single paragraph, so that typing Enter would result in pushing the
"Find Next" button.

The docked window/dialog mode, as opposed to a popped up dialog, could also
constitute a starting base for fixing #2625 "convert the search dialog to a
search bar" (a'la Firefox), so to implement a search-as-you-type behaviour.

Unfortunately, this feature would seem to need support for multiple views in the
same LyX window, e.g. like needed for #2143 "split-window view" (a'la MS-Word
Window->Split, or Emacs Ctrl-X 2 or Ctrl-X 3), something out of the current LyX
code structure.

I could find some time to help, if anyone wants to give me hints on what is the
correct direction of change.

Attachments (17)

lyx-findadv-gui.patch (21.3 KB ) - added by cucinotta@… 17 years ago.
Dockable Search GuiWorkArea
lyx-findadv-gui.2.patch (22.6 KB ) - added by cucinotta@… 17 years ago.
Dockable Search GuiWorkArea
lyx-findadv-gui.3.patch (33.8 KB ) - added by cucinotta@… 17 years ago.
Dockable Search GuiWorkArea
lyx-findadv-gui.4.patch (41.5 KB ) - added by cucinotta@… 17 years ago.
2015: Dockable Search GuiWorkArea
lyx-findadv-regexp.patch (79.1 KB ) - added by cucinotta@… 17 years ago.
Dockable Search GuiWorkArea (RegExp Enhanced)
lyx-findadv-regexp-mode.2.patch (88.4 KB ) - added by cucinotta@… 17 years ago.
Dockable Search GuiWorkArea (with RegExp Mode)
lyx-findadv-regexp-mode.patch (88.4 KB ) - added by cucinotta@… 17 years ago.
Dockable Search GuiWorkArea (with RegExp Mode)
lyx-findadv-regexp-mode-unstable.patch (89.6 KB ) - added by cucinotta@… 17 years ago.
2101: Dockable Search GuiWorkArea (with RegExp Mode, unstable)
lyx-findadv-regexp-mode.3.patch (88.4 KB ) - added by cucinotta@… 17 years ago.
Dockable Search GuiWorkArea (with RegExp Mode)
lyx-findadv-regexp-mode.4.patch (95.5 KB ) - added by cucinotta@… 17 years ago.
Dockable Search GuiWorkArea (with RegExp Mode)
lyx-findadv-regexp-mode.5.patch (94.9 KB ) - added by cucinotta@… 17 years ago.
Dockable Search GuiWorkArea (with RegExp Mode, rev 20067)
findadv.png (133.4 KB ) - added by cucinotta@… 17 years ago.
Screenshot of searching maths with the Advanced Search docked window.
findadv.2.png (133.4 KB ) - added by cucinotta@… 17 years ago.
Screenshot of searching maths with the Advanced Search docked window.
findadv-re.png (138.5 KB ) - added by cucinotta@… 17 years ago.
Screenshot of searching maths with REGEXPs and Advanced Search docked window
lyx-findadv-regexp-mode.6.patch (94.9 KB ) - added by cucinotta@… 16 years ago.
Dockable Search GuiWorkArea (with RegExp Mode, rev 20186)
lyx-findadv-regexp-mode.8.patch (111.7 KB ) - added by cucinotta@… 16 years ago.
Dockable Search GuiWorkArea (with RegExp Mode, rev 26819)
lyx-findadv-regexp-mode.7.patch (54.4 KB ) - added by cucinotta@… 16 years ago.
Dockable Search GuiWorkArea (with RegExp Mode, rev 26819)

Download all attachments as: .zip

Change History (61)

comment:1 by cucinotta@…, 17 years ago

dependson: 2143, 3982

comment:2 by Uwe Stöhr, 17 years ago

Severity: normalenhancement

comment:3 by Juergen Spitzmueller, 17 years ago

Cc: j.spitzmueller@… added

please check whether this report duplicates or conflicts with #2625. IMO one
of these two reports is obsolete.

comment:4 by younes, 17 years ago

#2625 is about a find bar ala firefox. This is for quick, text only, search IMO.

This one is for a more advanced search functionality. The content pane of the
search would use a temporary GuiWorkArea and some other controls. This new
dialog doesn't need to be a split view but rather a DockedWidget that can be
detached.

This is definitely doable.

by cucinotta@…, 17 years ago

Attachment: lyx-findadv-gui.patch added

Dockable Search GuiWorkArea

comment:5 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

comment:6 by younes, 17 years ago

patch is incomplete. File QSearchAdv is missing.

For multiple GuiWorkAreas per GuiView, please look at:

svn://svn.lyx.org/lyx/lyx-devel/branches/personal/younes/mvc

Abdel.

by cucinotta@…, 17 years ago

Attachment: lyx-findadv-gui.2.patch added

Dockable Search GuiWorkArea

comment:7 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

by cucinotta@…, 17 years ago

Attachment: lyx-findadv-gui.3.patch added

Dockable Search GuiWorkArea

comment:8 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

comment:9 by Uwe Stöhr, 17 years ago

Keywords: patch added
Milestone: 1.6.0

comment:10 by Uwe Stöhr, 17 years ago

dependson: 2143

comment:11 by Uwe Stöhr, 17 years ago

Cc: uwestoehr@… added

by cucinotta@…, 17 years ago

Attachment: lyx-findadv-gui.4.patch added

2015: Dockable Search GuiWorkArea

comment:12 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

by cucinotta@…, 17 years ago

Attachment: lyx-findadv-regexp.patch added

Dockable Search GuiWorkArea (RegExp Enhanced)

comment:13 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

comment:14 by Uwe Stöhr, 17 years ago

Subject: Re: Docked advanced search window

Great new patch! Could you please also post it at the lyx-devel list. Tomorrow the LyX developer
meeting begins and your new stuff should be one of the topics there.

by cucinotta@…, 17 years ago

Dockable Search GuiWorkArea (with RegExp Mode)

by cucinotta@…, 17 years ago

Dockable Search GuiWorkArea (with RegExp Mode)

comment:15 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

comment:16 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

comment:17 by younes, 17 years ago

Dear Tommaso,

Could you please update your patch to latest trunk and send it to the list. I
will help you get it in.

Abdel.

comment:18 by Uwe Stöhr, 17 years ago

Cc: younes.a@… added

Abdel, see comment 14

by cucinotta@…, 17 years ago

Dockable Search GuiWorkArea (with RegExp Mode)

comment:19 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

by cucinotta@…, 17 years ago

Dockable Search GuiWorkArea (with RegExp Mode)

comment:20 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

by cucinotta@…, 17 years ago

Dockable Search GuiWorkArea (with RegExp Mode, rev 20067)

comment:21 by cucinotta@…, 17 years ago

attachments.isobsolete: 01

comment:22 by alexl@…, 17 years ago

Cc: alexl@… added

comment:23 by younes, 17 years ago

Sorry Tommaso, I haven't followed up this patch as I promised I will do. I took
a new look at the patch and I understand now what is your problem with the
architecture. The solution is no to fit into the current GuiView but to create a
new class that derives from LyXView and that is specifically tailored to our need.

I'll try to implement that in the comming weeks (unless you want to do it). Then
it will be very easy to use this class for the advance search dialog.

Abdel.

by cucinotta@…, 17 years ago

Attachment: findadv.png added

Screenshot of searching maths with the Advanced Search docked window.

by cucinotta@…, 17 years ago

Attachment: findadv.2.png added

Screenshot of searching maths with the Advanced Search docked window.

by cucinotta@…, 17 years ago

Attachment: findadv-re.png added

Screenshot of searching maths with REGEXPs and Advanced Search docked window

comment:24 by Uwe Stöhr, 17 years ago

attachments.isobsolete: 01

comment:25 by Juergen Spitzmueller, 16 years ago

Milestone: 1.6.01.7.0

1.6 is feature-frozen.
Too bad this didn't make it into trunk yet.

comment:26 by cucinotta@…, 16 years ago

My old version of patched LyX still runs on my current Ubuntu 8.04, so I just
packed a couple of videos in order to show basic usage of the feature

http://de.youtube.com/watch?v=JxjMVvn7d3M

and usage of regular expressions

http://de.youtube.com/watch?v=Qqwwhu4VkGw

Hope this way people may see more easily if this would be an interesting feature
to have in LyX.

comment:27 by alexl@…, 16 years ago

looking at the videos from comment #24 this would be great feature to have in LyX!

comment:28 by ps@…, 16 years ago

Cc: ps@… added

comment:29 by Uwe Stöhr, 16 years ago

blocked: 2625

by cucinotta@…, 16 years ago

Dockable Search GuiWorkArea (with RegExp Mode, rev 20186)

comment:30 by cucinotta@…, 16 years ago

attachments.isobsolete: 01

comment:31 by ps@…, 16 years ago

Tommaso, this patch is incomplete, new files are missing.

comment:32 by ps@…, 16 years ago

moreover i just created special branch which should go in parallel with lyx 1.6
so people can start work on it together.
the svn path is: svn://svn.lyx.org/lyx/lyx-devel/branches/advsearch

all fixes be diffed against it.
as far as the missing files are concerned feel free to send me them privately i
add them to the repo.

by cucinotta@…, 16 years ago

Dockable Search GuiWorkArea (with RegExp Mode, rev 26819)

by cucinotta@…, 16 years ago

Dockable Search GuiWorkArea (with RegExp Mode, rev 26819)

comment:33 by cucinotta@…, 16 years ago

attachments.isobsolete: 01

comment:34 by ps@…, 16 years ago

thanks, its in.
unfortunately the gui part seems to be quite broken now.

comment:36 by Uwe Stöhr, 16 years ago

blocked: 4987

comment:37 by cucinotta@…, 15 years ago

Now I have a video on YouTube showing how to search for arbitrary text with
given style by using the current lyx-advsearch branch with a very basic use of
the regular expressions capability.

http://it.youtube.com/watch?v=0MR_O1ctIAY

comment:38 by Uwe Stöhr, 15 years ago

Keywords: fixedintrunk added

Fixed by Tommaso's new find and replace dialog, see
http://wiki.lyx.org/LyX/NewInLyX20

comment:39 by ps, 15 years ago

Priority: highlow

comment:40 by Tommaso Cucinotta, 15 years ago

Description: modified (diff)

I think this bug can be closed (it was just proposing the advanced search GUI as a docked pane, which is currently implemented in trunk).

comment:41 by Tommaso Cucinotta, 15 years ago

Resolution: fixed
Status: newclosed

No comment, so I'm closing.

comment:42 by Juergen Spitzmueller, 15 years ago

Resolution: fixed
Status: closedreopened

comment:43 by Juergen Spitzmueller, 15 years ago

Please do not close bugs that are not fixed in the stable version.

comment:44 by Uwe Stöhr, 14 years ago

Keywords: patch removed

comment:45 by ps, 13 years ago

Keywords: fixedintrunk removed
Resolution: fixed
Status: reopenedclosed

2.0.0 is ready.

Note: See TracTickets for help on using tickets.