Opened 17 years ago
Closed 13 years ago
#3998 closed enhancement (fixed)
Docked advanced search window
Reported by: | Owned by: | lasgouttes | |
---|---|---|---|
Priority: | low | Milestone: | 2.0.0 |
Component: | search | Version: | 1.5.0svn |
Severity: | minor | Keywords: | |
Cc: | j.spitzmueller@…, uwestoehr@…, alexl@…, younes@…, ps@… |
Description (last modified by )
Trying to split #3982 (feature enhancement) into multiple subtasks. There, I
proposed a search functionality allowing to type and edit the text to search
just like you do within any document, with the ability to enter text, math
symbols and subexpressions to find, and even other weird things (e.g. finding
labels, captions, styles, tables, floatings, references, etc...).
Here, I'd like to propose to implement the user-interface to such functionality
as a docked window that shows up, as a consequence of a keyboard shortcut or
menu selection, at the bottom of the LyX window. The window would contain a
full-enabled LyX widget allowing to enter the text to search, along with buttons
and checkboxes/radios. Possibly, editing of the search text could be restricted
to entering a single paragraph, so that typing Enter would result in pushing the
"Find Next" button.
The docked window/dialog mode, as opposed to a popped up dialog, could also
constitute a starting base for fixing #2625 "convert the search dialog to a
search bar" (a'la Firefox), so to implement a search-as-you-type behaviour.
Unfortunately, this feature would seem to need support for multiple views in the
same LyX window, e.g. like needed for #2143 "split-window view" (a'la MS-Word
Window->Split, or Emacs Ctrl-X 2 or Ctrl-X 3), something out of the current LyX
code structure.
I could find some time to help, if anyone wants to give me hints on what is the
correct direction of change.
Attachments (17)
Change History (61)
comment:1 by , 17 years ago
dependson: | → 2143, 3982 |
---|
comment:2 by , 17 years ago
Severity: | normal → enhancement |
---|
comment:3 by , 17 years ago
Cc: | added |
---|
comment:4 by , 17 years ago
#2625 is about a find bar ala firefox. This is for quick, text only, search IMO.
This one is for a more advanced search functionality. The content pane of the
search would use a temporary GuiWorkArea and some other controls. This new
dialog doesn't need to be a split view but rather a DockedWidget that can be
detached.
This is definitely doable.
comment:5 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:6 by , 17 years ago
patch is incomplete. File QSearchAdv is missing.
For multiple GuiWorkAreas per GuiView, please look at:
svn://svn.lyx.org/lyx/lyx-devel/branches/personal/younes/mvc
Abdel.
comment:7 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:8 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:9 by , 17 years ago
Keywords: | patch added |
---|---|
Milestone: | → 1.6.0 |
comment:10 by , 17 years ago
dependson: | 2143 |
---|
comment:11 by , 17 years ago
Cc: | added |
---|
comment:12 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
by , 17 years ago
Attachment: | lyx-findadv-regexp.patch added |
---|
Dockable Search GuiWorkArea (RegExp Enhanced)
comment:13 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:14 by , 17 years ago
Subject: Re: Docked advanced search window
Great new patch! Could you please also post it at the lyx-devel list. Tomorrow the LyX developer
meeting begins and your new stuff should be one of the topics there.
by , 17 years ago
Attachment: | lyx-findadv-regexp-mode.2.patch added |
---|
Dockable Search GuiWorkArea (with RegExp Mode)
by , 17 years ago
Attachment: | lyx-findadv-regexp-mode.patch added |
---|
Dockable Search GuiWorkArea (with RegExp Mode)
comment:15 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:16 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:17 by , 17 years ago
Dear Tommaso,
Could you please update your patch to latest trunk and send it to the list. I
will help you get it in.
Abdel.
by , 17 years ago
Attachment: | lyx-findadv-regexp-mode.3.patch added |
---|
Dockable Search GuiWorkArea (with RegExp Mode)
comment:19 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
by , 17 years ago
Attachment: | lyx-findadv-regexp-mode.4.patch added |
---|
Dockable Search GuiWorkArea (with RegExp Mode)
comment:20 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
by , 17 years ago
Attachment: | lyx-findadv-regexp-mode.5.patch added |
---|
Dockable Search GuiWorkArea (with RegExp Mode, rev 20067)
comment:21 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:22 by , 17 years ago
Cc: | added |
---|
comment:23 by , 17 years ago
Sorry Tommaso, I haven't followed up this patch as I promised I will do. I took
a new look at the patch and I understand now what is your problem with the
architecture. The solution is no to fit into the current GuiView but to create a
new class that derives from LyXView and that is specifically tailored to our need.
I'll try to implement that in the comming weeks (unless you want to do it). Then
it will be very easy to use this class for the advance search dialog.
Abdel.
by , 17 years ago
Attachment: | findadv.png added |
---|
Screenshot of searching maths with the Advanced Search docked window.
by , 17 years ago
Attachment: | findadv.2.png added |
---|
Screenshot of searching maths with the Advanced Search docked window.
by , 17 years ago
Attachment: | findadv-re.png added |
---|
Screenshot of searching maths with REGEXPs and Advanced Search docked window
comment:24 by , 17 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:25 by , 16 years ago
Milestone: | 1.6.0 → 1.7.0 |
---|
1.6 is feature-frozen.
Too bad this didn't make it into trunk yet.
comment:26 by , 16 years ago
My old version of patched LyX still runs on my current Ubuntu 8.04, so I just
packed a couple of videos in order to show basic usage of the feature
and usage of regular expressions
Hope this way people may see more easily if this would be an interesting feature
to have in LyX.
comment:27 by , 16 years ago
looking at the videos from comment #24 this would be great feature to have in LyX!
comment:28 by , 16 years ago
Cc: | added |
---|
comment:29 by , 16 years ago
blocked: | → 2625 |
---|
by , 16 years ago
Attachment: | lyx-findadv-regexp-mode.6.patch added |
---|
Dockable Search GuiWorkArea (with RegExp Mode, rev 20186)
comment:30 by , 16 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:32 by , 16 years ago
moreover i just created special branch which should go in parallel with lyx 1.6
so people can start work on it together.
the svn path is: svn://svn.lyx.org/lyx/lyx-devel/branches/advsearch
all fixes be diffed against it.
as far as the missing files are concerned feel free to send me them privately i
add them to the repo.
by , 16 years ago
Attachment: | lyx-findadv-regexp-mode.8.patch added |
---|
Dockable Search GuiWorkArea (with RegExp Mode, rev 26819)
by , 16 years ago
Attachment: | lyx-findadv-regexp-mode.7.patch added |
---|
Dockable Search GuiWorkArea (with RegExp Mode, rev 26819)
comment:33 by , 16 years ago
attachments.isobsolete: | 0 → 1 |
---|
comment:34 by , 16 years ago
thanks, its in.
unfortunately the gui part seems to be quite broken now.
comment:36 by , 16 years ago
blocked: | → 4987 |
---|
comment:37 by , 15 years ago
Now I have a video on YouTube showing how to search for arbitrary text with
given style by using the current lyx-advsearch branch with a very basic use of
the regular expressions capability.
comment:38 by , 15 years ago
Keywords: | fixedintrunk added |
---|
Fixed by Tommaso's new find and replace dialog, see
http://wiki.lyx.org/LyX/NewInLyX20
comment:39 by , 15 years ago
Priority: | high → low |
---|
comment:40 by , 15 years ago
Description: | modified (diff) |
---|
I think this bug can be closed (it was just proposing the advanced search GUI as a docked pane, which is currently implemented in trunk).
comment:42 by , 15 years ago
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:44 by , 14 years ago
Keywords: | patch removed |
---|
comment:45 by , 13 years ago
Keywords: | fixedintrunk removed |
---|---|
Resolution: | → fixed |
Status: | reopened → closed |
2.0.0 is ready.
please check whether this report duplicates or conflicts with #2625. IMO one
of these two reports is obsolete.