show changes in PDF fails for deleted straight quotes in some encodings other than T1

[Uwe Stöhr]

• open the attached LyX file
• try to export it as PDF

Result: You only get this LaTeX error:

! Argument of \T1\" has an extra }.

dvi or print} the \LyX{} document.

This only occurs when you use the option "Show changes in output".

The reason is the following: LyX creates this code:

\lyxdeleted{usti}{Sun Jul 27 15:13:54 2008}{\char`\"{}view
dvi or print} the \LyX{} document.

But for some reason the code must look this:

\lyxdeleted{usti}{Sun Jul 27 15:13:54 2008}{{}view
dvi or print} the \LyX{} document.

So neither the command
\char
nor
\"
are allowed in \lyxdeleted.

I don't know if we could fix this.

[Uwe Stöhr]

not compilable document -> major

Michael, do you have an idea?

[michael.gerz@…]

Hi Uwe,

I have worked on change tracking about a year ago... since then, a lot of things
have changed (probably)

\lyxdeleted is a macro. What happens if you expand it by hand? (i.e. export the
TeX file, resolve the macro and compile the TeX sources). Maybe the problem is
not \lyxdeleted but the commands used within \lyxdeleted...

I am not a LaTeX guru but maybe \protected is missing somewhere...

[Juergen Spitzmueller]

could you upload the text document?

[Juergen Spitzmueller]

OK, I see. The problem is that soul.sty breaks with \char.

[Juergen Spitzmueller]

patch

[Uwe Stöhr]

LyX testcase

[Uwe Stöhr]

Subject: Re: show changes in PDF output fails for deleted straight

quotes

Please test.

Works fine with the testcase I just attached.

Remaining problem: the document still won't compile with OT1 fontenc, because
OT1 doesn't know \textquotedbl (I guess this is why we use \char`")

I have no idea for a workaround here.

[lasgouttes]

The horrible \char notation is of course a consequence of the `feature' of
babel/german that uses this as shortcut. I think I used \string at some time in
the past, but it got replaced with the \char construct because latex2html
did not know how to handle it.

Now that I look at it I see in ot1enc.def:
\DeclareTextSymbol{\textquotedblright}{OT1}{`\"}

Are you sure it does not work?

[Juergen Spitzmueller]

Now that I look at it I see in ot1enc.def:
\DeclareTextSymbol{\textquotedblright}{OT1}{`\"}
Are you sure it does not work?

Yes. Probably the reason is that \textquotedblright != \textquotedbl ;-)

[lasgouttes]

Yes. Probably the reason is that \textquotedblright != \textquotedbl ;-)

Maybe :)

Then I would propose to put your patch in, but test the encoding instead
of testing whether change tracking is on. Also, what happens in tt font?
Can we use a plain ", or is babel stil plaing tricks on us?

[Juergen Spitzmueller]

Then I would propose to put your patch in, but test the encoding instead
of testing whether change tracking is on.

OK.

Also, what happens in tt font?
Can we use a plain ", or is babel stil playing tricks on us?

still playing tricks.

[Juergen Spitzmueller]

fixed for the T1 encoding in 1.6 and 1.5.7:
​http://www.lyx.org/trac/changeset/26212
​http://www.lyx.org/trac/changeset/26213

Other encodings (OT1, TS1 etc.) still have the problem. Note, however, that at
least OT1 does not output a proper "-glyph anyway.

[Juergen Spitzmueller]

Another remaining problem:

Paragraph::Private::latexSpecialT1 is called after checking (lyxrc.fontenc ==
"T1"), but some languages such as hebrew reset the font encoding internally
(e.g. to LHE), which is not noticed by LyX.

We probably need to add an additional language check.

[Juergen Spitzmueller]

problem in comment 13 is fixed:
​http://www.lyx.org/trac/changeset/27659
​http://www.lyx.org/trac/changeset/27660

[Juergen Spitzmueller]

The remainders are fixed in 1.6.2 and 2.0:
​http://www.lyx.org/trac/changeset/28114
​http://www.lyx.org/trac/changeset/28115

[Juergen Spitzmueller]

LyX 1.6.2 is released (announcement follows as soon as the binaries are built).

[Guenter Milde]

The "InternalEncoding" flag, that triggers the use of the "terrible" »\char`"« hack is
not required for a number of other font encodings that are compatible to T1 (other standard tex encodings, L7x, QX). See ticket #9652.