Opened 22 years ago

Closed 20 years ago

#578 closed defect (fixed)

Undo fails with itemize environments

Reported by: michael.gerz@… Owned by: nobody@…
Priority: high Milestone: 1.4.0
Component: undo/redo Version: 1.3.0cvs
Severity: normal Keywords: testcase
Cc: poenitz@…

Description

Undo fails partially with standard pars following "itemize" on incremented
environment depth

Test case "error-20020812-1.lyx" was posted to the mailing list.

Attachments (3)

breakparundo.diff​ (228 bytes ) - added by abraunst 20 years ago.
undo also the second par in a par break
error-20020812-1.lyx​ (1.1 KB ) - added by levon 20 years ago.
testcase
undo.lyx​ (1.3 KB ) - added by abraunst 20 years ago.
modified attachment

Download all attachments as: .zip

Change History (15)

comment:1 by michael.gerz@…, 22 years ago

Milestone: → 1.2.2

comment:2 by levon, 22 years ago

Component: general → lyxtext
Keywords: testcase added

comment:3 by levon, 22 years ago

Component: lyxtext → undo/redo

comment:4 by levon, 21 years ago

Milestone: 1.2.2

Resetting target milestone from 1.2.2

comment:5 by michael.gerz@…, 21 years ago

Version: 1.2.1 → 1.3.0cvs

comment:6 by levon, 21 years ago

Owner: changed from Lars Gullik Bjønnes to nobody@…

Lars doesn't want any bugs.

comment:7 by levon, 21 years ago

Milestone: → 1.4.0

let's see if the 1.4 undo reworking affects this bug

comment:8 by michael.gerz@…, 21 years ago

Cc: poenitz@… added

Unfortunately, the bug is still there.

comment:9 by michael.gerz@…, 21 years ago

BTW: No related valgrind report.

by abraunst, 20 years ago

Attachment: breakparundo.diff​ added

undo also the second par in a par break

by abraunst, 20 years ago

Attachment: undo.lyx​ added

modified attachment

by levon, 20 years ago

Attachment: error-20020812-1.lyx​ added

testcase

comment:10 by abraunst, 20 years ago

attachments.isobsolete: 0 → 1

comment:11 by abraunst, 20 years ago

Subject: lyx-devel src/: ChangeLog lyxtext.h text.C text2.C

CVSROOT: /usr/local/lyx/cvsroot
Module name: lyx-devel
Repository: lyx-devel/src/
Changes by: abraunst@… 04/01/09 10:04:35

Modified files:

lyx-devel/src/: ChangeLog lyxtext.h text.C text2.C

Log message:

add and LyXText::undoSpan to compute the influence of a layout change.
Fix #578.

Bugs:
#578

Patches:
​http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/ChangeLog?r1=1.1774&r2=1.1775
​http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/lyxtext.h?r1=1.272&r2=1.273
​http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/text.C?r1=1.514&r2=1.515
​http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/text2.C?r1=1.523&r2=1.524

Complete Diff:
/usr/bin/cvs -f diff -kk -u -r 1.1774 -r 1.1775 src/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.272 -r 1.273 src/lyxtext.h
/usr/bin/cvs -f diff -kk -u -r 1.514 -r 1.515 src/text.C
/usr/bin/cvs -f diff -kk -u -r 1.523 -r 1.524 src/text2.C

comment:12 by abraunst, 20 years ago

Resolution: → fixed
Status: new → closed

Fixed then

Note: See TracTickets for help on using tickets.