#656 closed defect (fixed)
Double quotes in subfigure labels confuse LyX on reading file
Reported by: | Owned by: | levon | |
---|---|---|---|
Priority: | high | Milestone: | 1.3.2 |
Component: | insetgraphics | Version: | 1.3.1 |
Severity: | major | Keywords: | dataloss patch VERIFIED |
Cc: | lasgouttes@… |
Description
I have subfigure labels which look like this (including the quotes):
"Raw"
"Corrected"
When LyX reads the saved file, it gets confused:
Unknown token, Raw"", skipping.
Unknown token, Corrected"", skipping.
Unknown token, Raw"", skipping.
Unknown token, Corrected"", skipping.
Unknown token, Raw"", skipping.
Unknown token, Corrected"", skipping.
It doesn't know how to deal with the embedded quotes in the label:
pelf% grep Raw ARLac.lyx
subcaptionText ""Raw""
subcaptionText ""Raw""
subcaptionText ""Raw""
Attachments (1)
Change History (11)
comment:1 by , 22 years ago
Cc: | added |
---|
comment:3 by , 21 years ago
Hmmm. We export this to LaTeX, which deals with it correctly
\begin{center}\subfigureRaw{\includegraphics[%
Why don't we save the same? Ie
subcaptionText "Raw"
and adjust LyXLex appropriately?
comment:4 by , 21 years ago
The solution is to replace
} else if (token == "subcaptionText") {
lex.next();
subcaptionText = lex.getString();
with something like
} else if (token == "subcaptionText") {
lex.eatLine();
subcaptionText = lex.getString();
I do not have much time to experiment, unfortunately.
comment:5 by , 21 years ago
Keywords: | dataloss added |
---|---|
Severity: | normal → major |
Version: | 1.2.1 → 1.3.1 |
comment:6 by , 21 years ago
Keywords: | patch added |
---|---|
Milestone: | → 1.3.2 |
Owner: | changed from | to
Not quite. A tested fix is attached - JMarc please look at this for 1.3.2
It handles " ", """, etc. OK
comment:7 by , 21 years ago
Keywords: | fixedintrunk added |
---|
comment:8 by , 21 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
Applied to branch too. Note that the "major" qualification is
a bit excessive, since one is not supposed to use " in
LaTeX :) A kind of punitive bug...
comment:10 by , 15 years ago
Keywords: | fixedintrunk removed |
---|
In 1.3 too. Should lyxlex just read to the last closing " ?