Opened 21 years ago

Closed 21 years ago

Last modified 21 years ago

#809 closed enhancement (fixed)

LyX resets document class if the TeX class is missing

Reported by: michael.gerz@… Owned by: nobody@…
Priority: high Milestone:
Component: general Version: 1.4.0cvs
Severity: minor Keywords: patch VERIFIED
Cc: levon@…, lasgouttes@…

Description

LyX resets the document class to "DocBook Article (SGML)" if the TeX class
for the original class is missing. IMHO this should not happen because

(a) DocBook is inappropriate in most cases and
(b) I would like to edit files on a machine on which

my TeX classes are not installed (or which has no TeX dist at all)

Does any LyX functionality (apart from LaTeX/DVI/... export/view) fail if a
TeX class is not installed? If not, a few disabled menu entry would
be lower price to pay.

Attachments (2)

textclass-patch (9.3 KB ) - added by michael.gerz@… 21 years ago.
Patch for 1.3.2cvs
docclass-patch-1.4 (9.9 KB ) - added by michael.gerz@… 21 years ago.
Patch for 1.4.0cvs (14 Apr 2003)

Download all attachments as: .zip

Change History (18)

comment:1 by levon, 21 years ago

This needs discussion on lyx-devel first. Confirming anyway.

comment:2 by michael.gerz@…, 21 years ago

Another good reason why this behavior should be changed (if possible without
breaking other things):

Imagine a curious user who has heard about LyX/Windows and wants to
have a quick look at it. Of course, he/she does not want to install
a full TeX installation just to get an impression. (S)He only installs
LyX, opens the user guide, and the first thing that LyX does is converting
the user guide into SGML DocBook Article :-(

comment:3 by levon, 21 years ago

Michael can you attach your patch ??

comment:4 by michael.gerz@…, 21 years ago

Cc: levon@… added

by michael.gerz@…, 21 years ago

Attachment: textclass-patch added

Patch for 1.3.2cvs

comment:5 by michael.gerz@…, 21 years ago

Cc: lasgouttes@… added

comment:6 by levon, 21 years ago

You got discussion on the list and I asked for the patch here, and it
took you two months. Why are you complaining about being ignored ?

by michael.gerz@…, 21 years ago

Attachment: docclass-patch-1.4 added

Patch for 1.4.0cvs (14 Apr 2003)

comment:7 by levon, 21 years ago

I still disagree with "No TeX". It's better than N/A, but not much.

Does this patch ensure that all the unavailable classes go last in the
combo box ?

comment:8 by michael.gerz@…, 21 years ago

Yes, unavailable classes go last such that they are not
visible at first (only if you scroll down).

If you don't like "No TeX:", please make a better proposal.
It should be a short text and used as a prefix for better perception.

comment:9 by levon, 21 years ago

Keywords: patch added
Severity: normalenhancement
Version: 1.3.0cvs1.4.0cvs

"Unavailable: "

With that change, the patch is OK by me, but I don't have
final say on this. That is: post the patch to the list with
the above change. If nobody complains, I'll apply it.

comment:10 by michael.gerz@…, 21 years ago

Patches for 1.3.2cvs and 1.4.0cvs sent to lyx-devel on April 24th 2003

comment:11 by levon, 21 years ago

Owner: changed from Lars Gullik Bjønnes to nobody@…

Lars doesn't want any bugs.

comment:12 by michael.gerz@…, 21 years ago

Lars asked me to do the sorting (i.e. moving unavailable document classes
to the end) in the frontends rather than in the kernel.

I will provide a corresponding patch soon but only for 1.4.0cvs.

The patch for 1.3.2cvs works very well, changing it may only
introduce new bugs, and finally I am sick of rewriting and testing
the same 5 lines again and again.

comment:13 by levon, 21 years ago

I dont think it's particularly appropriate for 1.3 anyway.

I'll apply your new patch when I get it.

comment:14 by levon, 21 years ago

Subject: lyx-devel lib/: chkconfig.ltx src/: ChangeLog bu ...

CVSROOT: /usr/local/lyx/cvsroot
Module name: lyx-devel
Repository: lyx-devel/src/frontends/xforms/
Changes by: levon@… 03/05/03 21:24:36

Modified files:

lyx-devel/lib/: chkconfig.ltx
lyx-devel/src/: ChangeLog bufferparams.C exporter.C

lyxtextclass.C lyxtextclass.h lyxtextclasslist.C

lyx-devel/src/frontends/qt2/: ChangeLog QDocument.C

QDocumentDialog.C

lyx-devel/src/frontends/xforms/: ChangeLog FormDocument.C

Log message:

#809 from Michael, and some small changes to it

Bugs:
#809

Patches:
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/lib/chkconfig.ltx?r1=1.11&r2=1.12
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/ChangeLog?r1=1.1293&r2=1.1294
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/bufferparams.C?r1=1.49&r2=1.50
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/exporter.C?r1=1.29&r2=1.30
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/lyxtextclass.C?r1=1.27&r2=1.28
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/lyxtextclass.h?r1=1.14&r2=1.15
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/lyxtextclasslist.C?r1=1.11&r2=1.12
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/frontends/qt2/ChangeLog?r1=1.496&r2=1.497
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/frontends/qt2/QDocument.C?r1=1.45&r2=1.46
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/frontends/qt2/QDocumentDialog.C?r1=1.28&r2=1.29
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/frontends/xforms/ChangeLog?r1=1.740&r2=1.741
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/frontends/xforms/FormDocument.C?r1=1.137&r2=1.138

Complete Diff:
/usr/bin/cvs -f diff -kk -u -r 1.11 -r 1.12 lib/chkconfig.ltx
/usr/bin/cvs -f diff -kk -u -r 1.1293 -r 1.1294 src/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.49 -r 1.50 src/bufferparams.C
/usr/bin/cvs -f diff -kk -u -r 1.29 -r 1.30 src/exporter.C
/usr/bin/cvs -f diff -kk -u -r 1.27 -r 1.28 src/lyxtextclass.C
/usr/bin/cvs -f diff -kk -u -r 1.14 -r 1.15 src/lyxtextclass.h
/usr/bin/cvs -f diff -kk -u -r 1.11 -r 1.12 src/lyxtextclasslist.C
/usr/bin/cvs -f diff -kk -u -r 1.496 -r 1.497 src/frontends/qt2/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.45 -r 1.46 src/frontends/qt2/QDocument.C
/usr/bin/cvs -f diff -kk -u -r 1.28 -r 1.29 src/frontends/qt2/QDocumentDialog.C
/usr/bin/cvs -f diff -kk -u -r 1.740 -r 1.741 src/frontends/xforms/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.137 -r 1.138 src/frontends/xforms/FormDocument.C

comment:15 by levon, 21 years ago

Resolution: fixed
Status: newclosed

applied to head

comment:16 by levon, 21 years ago

Keywords: VERIFIED added
Note: See TracTickets for help on using tickets.