Opened 21 years ago

Closed 21 years ago

Last modified 15 years ago

#920 closed defect (fixed)

Disabling inline graphics does not disable graphics conversion

Reported by: chr Owned by: levon
Priority: high Milestone: 1.3.1
Component: insetgraphics Version: 1.3.0
Severity: major Keywords: patch
Cc: lasgouttes@…, leeming@…

Description

I work with grahics disabled inside Lyx. However, 1.3.0 and 1.4.0cvs still
converts the images (although the images aren't shown in lyx)

This behaviour can actually be annoying if your document has lots of graphics...

Attachments (1)

a.diff (1.5 KB ) - added by levon 21 years ago.
minimal fix

Download all attachments as: .zip

Change History (12)

comment:1 by levon, 21 years ago

Severity: minormajor

comment:2 by levon, 21 years ago

Component: convertorsinsetgraphics

comment:3 by levon, 21 years ago

Cc: leeming@… added

see #335 too

comment:4 by levon, 21 years ago

Cc: lasgouttes@… added
Keywords: patch added
Milestone: 1.3.1
Owner: changed from dekel to levon

I have a minimal fix for both bugs, change the text
given by WaitingToLoad, and not calling load in ::draw()
if as_grfxParams().display == NoDisplay.

Sound OK Angus ? I won't be drawn into doing anything further
with this code ;)

comment:5 by leeming, 21 years ago

Sounds fine. Go ahead. (and why not by the way? The stuff in src/graphics is
pretty clean and extendable, as Alfredo is demonstrating.)

comment:6 by levon, 21 years ago

It's insets/insetgraphics that scares me not graphics/

I'll apply it to head ...

comment:7 by leeming, 21 years ago

Ahhh. Scares the st out of me too ;-)

by levon, 21 years ago

Attachment: a.diff added

minimal fix

comment:8 by levon, 21 years ago

Keywords: fixedintrunk added
Status: newassigned

JMarc, please consider attached.

comment:9 by lasgouttes, 21 years ago

Please apply to 1.3.1cvs too. This is really a stupid bug.

comment:10 by levon, 21 years ago

Resolution: fixed
Status: assignedclosed

done. I also backed out my accidental mention of the spell reworking
in status.13x ;)

comment:11 by ps@…, 15 years ago

Keywords: fixedintrunk removed
Note: See TracTickets for help on using tickets.