Opened 22 years ago

Closed 19 years ago

#605 closed defect (fixed)

lyx input nesting incorrecly extracted in temporary directory

Reported by: jras@… Owned by: lasgouttes
Priority: high Milestone: 1.3.3
Component: general Version: 1.2.1
Severity: normal Keywords:
Cc: lasgouttes@…, dekelts@…, georg.baum@…, cengique@…

Description

First, i am not sure if this is an error or just the normal behaviour,
but in any case if it could be of any help...

When i use nested "input" (not include) with ".lyx" files and i try to view
the result i get a latex error about the last level file ".tex" file not found.

It seems to me that the problem is that in the temporary directory used to
do the rendering, the "input" are only extracted to .tex files in the first
level in the main directory, and the second level of "input" is extracted
to the other temporary directory of that second level file, instead of the
main file.

On the other hand the "export to LaTeX" with two levels of input using
.lyx files works well and all the files in the second level of nesting are
extracted correctly.
By the way, this is a temporary work around, because if i export to LaTeX
the main file, all the second level files are also extracted correctly and
as there exist the .tex files in the normal directory the rendering then
works ok (except changing any second level input file that requires a new
export).

Attachments (4)

includes.diff (13.6 KB ) - added by lasgouttes 21 years ago.
A first patch
Patch-605.txt (9.4 KB ) - added by stephan.witt@… 21 years ago.
Patch against lyx-1.2.3 to fix this bug
bug605-2.diff (17.3 KB ) - added by lasgouttes 20 years ago.
Patch ported to 1.3.4 (or 1.3.5cvs)
includes2.diff (17.3 KB ) - added by lasgouttes 20 years ago.
A better one

Download all attachments as: .zip

Change History (31)

comment:1 by levon, 22 years ago

Cc: dekelts@… added

I don't think input is supposed to be used with .lyx files at all ?

comment:2 by dekel, 22 years ago

No, you can use input with .lyx files.
I have no ide why the file dialog sets the pattern to *.tex
and not *.(lyx|tex)

comment:3 by lasgouttes, 21 years ago

Cc: lasgouttes@… added
Milestone: 1.3.0

Ths should be fixed, I think

comment:4 by levon, 21 years ago

Milestone: 1.3.01.3.1

1.3.0 bugs are now 1.3.1 bugs

comment:5 by lasgouttes, 21 years ago

Status: newassigned

I forgot to say: this patch is against 1.3.X, but should apply to 1.4.0cvs too.

by lasgouttes, 21 years ago

Attachment: includes.diff added

A first patch

comment:6 by lasgouttes, 21 years ago

attachments.isobsolete: 01

by stephan.witt@…, 21 years ago

Attachment: Patch-605.txt added

Patch against lyx-1.2.3 to fix this bug

comment:7 by cengique@…, 21 years ago

Cc: cengiz@… added

comment:8 by cengique@…, 21 years ago

* #927 has been marked as a duplicate of this bug. *

comment:9 by levon, 21 years ago

Owner: changed from Lars Gullik Bjønnes to nobody@…
Status: assignednew

Lars doesn't want any bugs.

comment:10 by cengique@…, 21 years ago

I have been using the patch provided by Stephan Witt (originally by Jean Marc)
and tested it with my 133 page document which consists of files of all kinds
spread over many directory hierarchies. Anyway, the point is that it works!

I would very much like to see this patch in the CVS. I couldn't understand what
exactly you like us to test for the graphics insets? I didn't have any problems
with them in the first place?

Please let me know how I can help you test the patch further.

comment:11 by lasgouttes, 21 years ago

I think the problematic case was something like

file foo1.lyx inputs dir1/foo2.lyx
file dir1/foo2.lyx inputs dir1/dir2/foo3.lyx
file dir1/dir2/foo3.lyx uses graphics graph.eps (in dir1/dir2)

the \includegraphics for graph.eps should read
\includegraphics{dir1/dir2/graph.eps}
but it did not.

Basically, I think that this patch works, except for external
inset (should not be too difficult to fix, but we want
a different handling for latex and docbook). Since I want to
release 1.3.2 very soon, I will have to delay the patch again, and I
am sorry about that. What I will do however is to produce a
patch against 1.3.2 just after the release...

comment:12 by levon, 21 years ago

Milestone: 1.3.11.3.3
Owner: changed from nobody@… to lasgouttes

JMarc, it's post 1.3.2. Status ?

comment:13 by lasgouttes, 21 years ago

I'd like to have time to finish this either at chemnitz or the week after.

For 1.4.0cvs, I am not sure what the situation is now. Do inset have access
to their buffer?

comment:14 by Lars Gullik Bjønnes, 21 years ago

What is the status on this one?
There seem to exist a patch, but has it been applied?

comment:15 by cengique@…, 20 years ago

As of 1.3.4, the patch is still not applied.

by lasgouttes, 20 years ago

Attachment: includes2.diff added

Patch ported to 1.3.4 (or 1.3.5cvs)

comment:16 by lasgouttes, 20 years ago

attachments.isobsolete: 01

comment:17 by cengique@…, 20 years ago

The patch seem to work fine in 1.3.4. I tested a few large documents that
require the patch. Thanks..

comment:18 by Georg Baum, 20 years ago

Cc: georg.baum@… added

comment:19 by leeming, 20 years ago

Subject: lyx-devel po/: POTFILES.in src/: ChangeLog buffe ...

CVSROOT: /usr/local/lyx/cvsroot
Module name: lyx-devel
Repository: lyx-devel/src/insets/
Changes by: leeming@… 04/03/25 11:12:44

Modified files:

lyx-devel/po/: POTFILES.in
lyx-devel/src/: ChangeLog buffer.C buffer.h
lyx-devel/src/insets/: ChangeLog ExternalSupport.C

insetgraphics.C insetinclude.C

Log message:

Georg's take on #605.

Bugs:
#605

Patches:
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/po/POTFILES.in?r1=1.381&r2=1.382
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/ChangeLog?r1=1.1843&r2=1.1844
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/buffer.C?r1=1.561&r2=1.562
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/buffer.h?r1=1.182&r2=1.183
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/ChangeLog?r1=1.977&r2=1.978
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/ExternalSupport.C?r1=1.4&r2=1.5
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/insetgraphics.C?r1=1.238&r2=1.239
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/insetinclude.C?r1=1.185&r2=1.186

Complete Diff:
/usr/bin/cvs -f diff -kk -u -r 1.381 -r 1.382 po/POTFILES.in
/usr/bin/cvs -f diff -kk -u -r 1.1843 -r 1.1844 src/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.561 -r 1.562 src/buffer.C
/usr/bin/cvs -f diff -kk -u -r 1.182 -r 1.183 src/buffer.h
/usr/bin/cvs -f diff -kk -u -r 1.977 -r 1.978 src/insets/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.4 -r 1.5 src/insets/ExternalSupport.C
/usr/bin/cvs -f diff -kk -u -r 1.238 -r 1.239 src/insets/insetgraphics.C
/usr/bin/cvs -f diff -kk -u -r 1.185 -r 1.186 src/insets/insetinclude.C

comment:20 by leeming, 20 years ago

Subject: lyx-devel lib/: ChangeLog external_templates src ...

CVSROOT: /usr/local/lyx/cvsroot
Module name: lyx-devel
Repository: lyx-devel/src/insets/
Changes by: leeming@… 04/04/06 23:07:27

Modified files:

lyx-devel/lib/: ChangeLog external_templates
lyx-devel/src/insets/: ChangeLog ExternalSupport.C

Log message:

Georg's latest contribution to squashing #605.

Bugs:
#605

Patches:
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/lib/ChangeLog?r1=1.578&r2=1.579
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/lib/external_templates?r1=1.22&r2=1.23
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/ChangeLog?r1=1.995&r2=1.996
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/ExternalSupport.C?r1=1.5&r2=1.6

Complete Diff:
/usr/bin/cvs -f diff -kk -u -r 1.578 -r 1.579 lib/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.22 -r 1.23 lib/external_templates
/usr/bin/cvs -f diff -kk -u -r 1.995 -r 1.996 src/insets/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.5 -r 1.6 src/insets/ExternalSupport.C

comment:21 by lasgouttes, 20 years ago

Subject: lyx-devel po/: POTFILES.in src/: ChangeLog LaTeX ...

CVSROOT: /usr/local/lyx/cvsroot
Module name: lyx-devel
Repository: lyx-devel/src/insets/
Changes by: lasgouttes@… 04/04/08 12:09:09

Modified files:

lyx-devel/po/: POTFILES.in
lyx-devel/src/: ChangeLog LaTeXFeatures.C LaTeXFeatures.h
lyx-devel/src/insets/: ChangeLog insetinclude.C

Log message:

Georg\'s last patch for #605

Bugs:
#605

Patches:
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/po/POTFILES.in?r1=1.385&r2=1.386
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/ChangeLog?r1=1.1886&r2=1.1887
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/LaTeXFeatures.C?r1=1.106&r2=1.107
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/LaTeXFeatures.h?r1=1.55&r2=1.56
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/ChangeLog?r1=1.998&r2=1.999
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/insetinclude.C?r1=1.187&r2=1.188

Complete Diff:
/usr/bin/cvs -f diff -kk -u -r 1.385 -r 1.386 po/POTFILES.in
/usr/bin/cvs -f diff -kk -u -r 1.1886 -r 1.1887 src/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.106 -r 1.107 src/LaTeXFeatures.C
/usr/bin/cvs -f diff -kk -u -r 1.55 -r 1.56 src/LaTeXFeatures.h
/usr/bin/cvs -f diff -kk -u -r 1.998 -r 1.999 src/insets/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.187 -r 1.188 src/insets/insetinclude.C

comment:22 by Georg Baum, 20 years ago

This is fixed in 1.4.0cvs now. Note to comment #17: The external material inset
was fixed by introducing new variables and redefining existing ones. I don't
think this makes sense for 1.3, and it is IMHO not possible to fix the bug
without redefining variables. Therefore the latest patch at http://
bugzilla.lyx.org/attachment.cgi?id=534&action=view could be applied, fixing
everything but external material.


Georg

comment:23 by cengique@…, 20 years ago

Sorry couldn't hold myself from saying this:

A patch a day keeps the bugs away.

-some wise man


:) I'll start looking at 1.4.0cvs as soon as I can, sounds intriguing. I
assume this is the HEAD branch, since I couldn't find a branch tagged with
this name.

comment:24 by lasgouttes, 20 years ago

Subject: lyx-devel /: Tag: BRANCH_1_3_X status.13x src/: ...

CVSROOT: /usr/local/lyx/cvsroot
Module name: lyx-devel
Repository: lyx-devel/src/insets/
Changes by: lasgouttes@… 04/04/18 17:36:05

Modified files:

lyx-devel/: Tag: BRANCH_1_3_X status.13x
lyx-devel/src/: Tag: BRANCH_1_3_X BufferView_pimpl.C ChangeLog

buffer.C buffer.h

lyx-devel/src/frontends/controllers/: Tag: BRANCH_1_3_X

ChangeLog ControlInclude.C

lyx-devel/src/insets/: Tag: BRANCH_1_3_X ChangeLog

insetgraphics.C insetinclude.C
insetinclude.h

Log message:

partial fix for #605

Bugs:
#605

Patches:
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/status.13x?r1=1.1.2.175&r2=1.1.2.176
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/BufferView_pimpl.C?r1=1.322.2.1&r2=1.322.2.2
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/ChangeLog?r1=1.1021.2.30&r2=1.1021.2.31
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/buffer.C?r1=1.399.2.6&r2=1.399.2.7
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/buffer.h?r1=1.117&r2=1.117.2.1
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/frontends/controllers/ChangeLog?r1=1.273.2.5&r2=1.273.2.6
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/frontends/controllers/ControlInclude.C?r1=1.32&r2=1.32.2.1
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/ChangeLog?r1=1.552.2.10&r2=1.552.2.11
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/insetgraphics.C?r1=1.146.2.2&r2=1.146.2.3
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/insetinclude.C?r1=1.91.2.1&r2=1.91.2.2
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/insetinclude.h?r1=1.52&r2=1.52.2.1

Complete Diff:
/usr/bin/cvs -f diff -kk -u -r 1.1.2.175 -r 1.1.2.176 /status.13x
/usr/bin/cvs -f diff -kk -u -r 1.322.2.1 -r 1.322.2.2 src/BufferView_pimpl.C
/usr/bin/cvs -f diff -kk -u -r 1.1021.2.30 -r 1.1021.2.31 src/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.399.2.6 -r 1.399.2.7 src/buffer.C
/usr/bin/cvs -f diff -kk -u -r 1.117 -r 1.117.2.1 src/buffer.h
/usr/bin/cvs -f diff -kk -u -r 1.273.2.5 -r 1.273.2.6 src/frontends/controllers/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.32 -r 1.32.2.1 src/frontends/controllers/ControlInclude.C
/usr/bin/cvs -f diff -kk -u -r 1.552.2.10 -r 1.552.2.11 src/insets/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.146.2.2 -r 1.146.2.3 src/insets/insetgraphics.C
/usr/bin/cvs -f diff -kk -u -r 1.91.2.1 -r 1.91.2.2 src/insets/insetinclude.C
/usr/bin/cvs -f diff -kk -u -r 1.52 -r 1.52.2.1 src/insets/insetinclude.h

comment:25 by lasgouttes, 20 years ago

Subject: lyx-devel /: Tag: BRANCH_1_3_X status.13x src/in ...

CVSROOT: /usr/local/lyx/cvsroot
Module name: lyx-devel
Repository: lyx-devel/src/insets/
Changes by: lasgouttes@… 04/04/19 17:21:19

Modified files:

lyx-devel/: Tag: BRANCH_1_3_X status.13x
lyx-devel/src/insets/: Tag: BRANCH_1_3_X ChangeLog insetbib.C

Log message:

fix bibtex file name handling (related to #605)

Bugs:
#605

Patches:
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/status.13x?r1=1.1.2.176&r2=1.1.2.177
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/ChangeLog?r1=1.552.2.11&r2=1.552.2.12
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/insetbib.C?r1=1.97&r2=1.97.2.1

Complete Diff:
/usr/bin/cvs -f diff -kk -u -r 1.1.2.176 -r 1.1.2.177 /status.13x
/usr/bin/cvs -f diff -kk -u -r 1.552.2.11 -r 1.552.2.12 src/insets/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.97 -r 1.97.2.1 src/insets/insetbib.C

comment:26 by lasgouttes, 20 years ago

Subject: lyx-devel src/insets/: ChangeLog insetbibtex.C i ...

CVSROOT: /usr/local/lyx/cvsroot
Module name: lyx-devel
Repository: lyx-devel/src/insets/
Changes by: lasgouttes@… 04/04/20 14:46:16

Modified files:

lyx-devel/src/insets/: ChangeLog insetbibtex.C insetoptarg.h

Log message:

another fix related to #605; fix toggling of optarg inset

Bugs:
#605

Patches:
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/ChangeLog?r1=1.1006&r2=1.1007
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/insetbibtex.C?r1=1.47&r2=1.48
http://www.lyx.org/cgi-bin/viewcvs.cgi/lyx-devel/src/insets/insetoptarg.h?r1=1.20&r2=1.21

Complete Diff:
/usr/bin/cvs -f diff -kk -u -r 1.1006 -r 1.1007 src/insets/ChangeLog
/usr/bin/cvs -f diff -kk -u -r 1.47 -r 1.48 src/insets/insetbibtex.C
/usr/bin/cvs -f diff -kk -u -r 1.20 -r 1.21 src/insets/insetoptarg.h

comment:27 by cengique@…, 19 years ago

I just wanted to thank you guys for including the patch to this bug in the
current 1.3.5 release. I can finally share documents with regular lyx users.
Cheers..

comment:28 by lasgouttes, 19 years ago

Resolution: fixed
Status: newclosed

You are very welcome. It took time!

Since the fix in 1.3.5 is good enough (even if it does less than
1.4.0cvs), I close the bug.

Note: See TracTickets for help on using tickets.